Add favicon and related assets #14

2026-04-04T06:53:49Z

N0tAI commented

2026-04-04 06:53:49 +00:00

(Migrated from github.com)

Added a favicon svg and an svg to generate app icons (in the unlikely event that someone saves it as an app).
Additionally added a script to automatically generate the requisite pngs for various platforms to avoid carrying the images themselves around in this repo.

NOTE: the SVGs are imperfect rn and will need to be edited later to be 'perfect'

Added a favicon svg and an svg to generate app icons (in the unlikely event that someone saves it as an app). Additionally added a script to automatically generate the requisite pngs for various platforms to avoid carrying the images themselves around in this repo. NOTE: the SVGs are imperfect rn and will need to be edited later to be 'perfect'

👀 1

gemini-code-assist[bot] (Migrated from github.com) reviewed

2026-04-04 06:54:50 +00:00

gemini-code-assist[bot] (Migrated from github.com) left a comment

Code Review

This pull request implements a comprehensive icon system, introducing SVG source files, a web manifest, and a shell script to generate various icon formats using ImageMagick. The site layout has been updated to reference these new assets, and a related TODO was removed. Feedback focuses on improving the robustness of the icon generation script by adding error handling and optimizing the apple-touch-icon size to reduce bandwidth usage on mobile devices.

## Code Review This pull request implements a comprehensive icon system, introducing SVG source files, a web manifest, and a shell script to generate various icon formats using ImageMagick. The site layout has been updated to reference these new assets, and a related TODO was removed. Feedback focuses on improving the robustness of the icon generation script by adding error handling and optimizing the apple-touch-icon size to reduce bandwidth usage on mobile devices.

scripts/mkicons.sh

					
				@ -0,0 +1,15 @@

				#!/bin/bash

It is recommended to add set -e to the script to ensure it exits immediately if any command (like magick) fails. This prevents the script from continuing in an inconsistent state if ImageMagick is not installed or if an error occurs during icon generation.

#!/bin/bash
set -e

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) It is recommended to add `set -e` to the script to ensure it exits immediately if any command (like `magick`) fails. This prevents the script from continuing in an inconsistent state if ImageMagick is not installed or if an error occurs during icon generation. ```suggestion #!/bin/bash set -e ```

src/layouts/site_layout.astro

					
				@ -8,7 +8,10 @@ const { title, description } = Astro.props;

				<html lang="en">

The apple-touch-icon is currently pointing to a 1024x1024 image. This is significantly larger than the standard 180x180 size recommended by Apple, leading to unnecessary bandwidth usage on mobile devices. Using the 192x192 version instead would be more efficient while still providing high quality for high-density displays.

    <link rel="apple-touch-icon" type="image/png" href="/thayen-dev-192.png" />

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) The `apple-touch-icon` is currently pointing to a 1024x1024 image. This is significantly larger than the standard 180x180 size recommended by Apple, leading to unnecessary bandwidth usage on mobile devices. Using the 192x192 version instead would be more efficient while still providing high quality for high-density displays. ``` <link rel="apple-touch-icon" type="image/png" href="/thayen-dev-192.png" /> ```

Sign in to join this conversation.

No reviewers