thayen/portfolio-site
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions 1

Emergency fixes to try and fix downed site #17

Merged
N0tAI merged 3 commits from update into main 2026-04-04 08:41:06 +00:00
Conversation 2 Commits 3 Files changed 5 +20 -87
N0tAI commented 2026-04-04 08:24:14 +00:00 (Migrated from github.com)
Copy link
No description provided.
👀 1
gemini-code-assist[bot] (Migrated from github.com) reviewed 2026-04-04 08:29:16 +00:00
gemini-code-assist[bot] (Migrated from github.com) left a comment
Copy link

Code Review

This pull request updates @types/node dependencies in the lockfile and renames the Cloudflare Worker in wrangler.jsonc. A review comment highlights significant operational risks associated with renaming the worker from portfolio-worker to thayen-dev-worker, specifically regarding secrets migration, custom domain bindings, and potential CI/CD pipeline breakages.

## Code Review This pull request updates @types/node dependencies in the lockfile and renames the Cloudflare Worker in wrangler.jsonc. A review comment highlights significant operational risks associated with renaming the worker from portfolio-worker to thayen-dev-worker, specifically regarding secrets migration, custom domain bindings, and potential CI/CD pipeline breakages.
wrangler.jsonc
@ -1,5 +1,5 @@
{
"name": "portfolio-worker",
"name": "thayen-dev-worker",
"compatibility_date": "2026-04-03",
gemini-code-assist[bot] (Migrated from github.com) commented 2026-04-04 08:29:16 +00:00
Copy link

high

Renaming the worker from portfolio-worker to thayen-dev-worker in an emergency PR carries significant operational risks that could prolong the downtime:

  1. Secrets Migration: Cloudflare Workers secrets (set via wrangler secret put) are scoped to the worker name. Renaming the worker will result in a new deployment that lacks all previously configured secrets, likely causing runtime failures if the application relies on them.
  2. Custom Domain Binding: The custom domain thayen.dev is currently bound to the worker. Renaming the worker requires Cloudflare to re-associate the domain with the new worker name, which can sometimes fail or cause propagation delays if the old worker still holds the binding.
  3. CI/CD Pipelines: If your deployment pipeline or monitoring tools reference the worker by name, they will break after this change.

If the goal is to fix a downed site, consider if a rename is truly necessary at this moment.

![high](https://www.gstatic.com/codereviewagent/high-priority.svg) Renaming the worker from `portfolio-worker` to `thayen-dev-worker` in an emergency PR carries significant operational risks that could prolong the downtime: 1. **Secrets Migration**: Cloudflare Workers secrets (set via `wrangler secret put`) are scoped to the worker name. Renaming the worker will result in a new deployment that lacks all previously configured secrets, likely causing runtime failures if the application relies on them. 2. **Custom Domain Binding**: The custom domain `thayen.dev` is currently bound to the worker. Renaming the worker requires Cloudflare to re-associate the domain with the new worker name, which can sometimes fail or cause propagation delays if the old worker still holds the binding. 3. **CI/CD Pipelines**: If your deployment pipeline or monitoring tools reference the worker by name, they will break after this change. If the goal is to fix a downed site, consider if a rename is truly necessary at this moment.
N0tAI (Migrated from github.com) reviewed 2026-04-04 08:34:02 +00:00
wrangler.jsonc
@ -1,5 +1,5 @@
{
"name": "portfolio-worker",
"name": "thayen-dev-worker",
"compatibility_date": "2026-04-03",
N0tAI (Migrated from github.com) commented 2026-04-04 08:34:02 +00:00
Copy link

I already renamed it as a test to see what was wrong, this is necessary to reach the new name of the worker per cloudflare.

I already renamed it as a test to see what was wrong, this is necessary to reach the new name of the worker per cloudflare.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
javascript
Pull requests that update javascript code

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
javascript
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thayen/portfolio-site!17
No description provided.