Content changes to site #19
No reviewers
Labels
No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
javascript
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
thayen/portfolio-site!19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "content"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Made some changes to the porfolio content to hopefully make it more presentable/appealing
Code Review
This pull request updates the portfolio content by refining the skills list, updating the professional bio, and standardizing indentation across several files. It also simplifies the site layout by hardcoding the page title. Feedback highlights a dangling comma in the skills list that will likely render as literal text in the browser, and recommends restoring dynamic page titles in the layout to maintain SEO flexibility and accessibility.
@ -4,3 +4,3 @@import "../styles/torch.css";const { title, description } = Astro.props;const { description } = Astro.props;---Removing the
titleprop from the layout's props destructuring makes it unavailable for use in the<title>tag. It is recommended to keep the layout flexible so that different pages can provide their own titles for SEO and accessibility purposes.Hardcoding the title string directly in the layout prevents pages from setting unique titles. This can negatively impact SEO and make it harder for users to distinguish between pages in browser tabs or history. Using a dynamic title with a fallback is a better approach.
@ -95,28 +90,16 @@ import SiteLayout from "@/layouts/site_layout.astro";<Keyword><Fragment slot="display">JavaScript/Typescript</Fragment>The trailing comma after the last
<Keyword>component will be rendered as literal text in the browser. Since this is now the last item in the list, the comma should be removed to avoid a dangling comma in the UI.@ -4,3 +4,3 @@import "../styles/torch.css";const { title, description } = Astro.props;const { description } = Astro.props;---No other pages planned
No other pages planned