Update from main #7
No reviewers
Labels
No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
javascript
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
thayen/portfolio-site!7
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "main"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Code Review
This pull request removes
@esbuild/android-armdependencies from the lockfile across multiple versions and introduces a workspace configuration inpnpm-workspace.yaml. The review feedback highlights that the removal of 32-bit ARM support may be unintentional and suggests that the workspace configuration is redundant for a single-package repository, recommending the relocation of settings topackage.jsonto simplify the project structure.The optional dependency
@esbuild/android-armhas been removed from the lockfile for multiple versions ofesbuild(0.25.12, 0.25.4, and 0.27.3), while other niche platforms likeaix-ppc64remain. This inconsistency suggests an accidental deletion or a configuration issue during lockfile generation. If support for 32-bit ARM Android devices is required, these entries should be restored by runningpnpm installin an environment that includes all supported architectures.@ -1,3 +1,6 @@packages:- "."Adding
packages: ["."]topnpm-workspace.yamlis generally unnecessary for a single-package repository. For such projects, it is recommended to move theonlyBuiltDependenciesconfiguration to thepnpmfield inpackage.jsonand remove thepnpm-workspace.yamlfile entirely. This simplifies the project structure and avoids the overhead of pnpm's workspace logic.