Update from main #7

Merged
N0tAI merged 8 commits from main into dev 2026-04-03 02:40:13 +00:00
N0tAI commented 2026-04-03 02:40:05 +00:00 (Migrated from github.com)
No description provided.
gemini-code-assist[bot] (Migrated from github.com) reviewed 2026-04-03 02:42:43 +00:00
gemini-code-assist[bot] (Migrated from github.com) left a comment

Code Review

This pull request removes @esbuild/android-arm dependencies from the lockfile across multiple versions and introduces a workspace configuration in pnpm-workspace.yaml. The review feedback highlights that the removal of 32-bit ARM support may be unintentional and suggests that the workspace configuration is redundant for a single-package repository, recommending the relocation of settings to package.json to simplify the project structure.

## Code Review This pull request removes `@esbuild/android-arm` dependencies from the lockfile across multiple versions and introduces a workspace configuration in `pnpm-workspace.yaml`. The review feedback highlights that the removal of 32-bit ARM support may be unintentional and suggests that the workspace configuration is redundant for a single-package repository, recommending the relocation of settings to `package.json` to simplify the project structure.
gemini-code-assist[bot] (Migrated from github.com) commented 2026-04-03 02:42:43 +00:00

medium

The optional dependency @esbuild/android-arm has been removed from the lockfile for multiple versions of esbuild (0.25.12, 0.25.4, and 0.27.3), while other niche platforms like aix-ppc64 remain. This inconsistency suggests an accidental deletion or a configuration issue during lockfile generation. If support for 32-bit ARM Android devices is required, these entries should be restored by running pnpm install in an environment that includes all supported architectures.

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) The optional dependency `@esbuild/android-arm` has been removed from the lockfile for multiple versions of `esbuild` (0.25.12, 0.25.4, and 0.27.3), while other niche platforms like `aix-ppc64` remain. This inconsistency suggests an accidental deletion or a configuration issue during lockfile generation. If support for 32-bit ARM Android devices is required, these entries should be restored by running `pnpm install` in an environment that includes all supported architectures.
@ -1,3 +1,6 @@
packages:
- "."
gemini-code-assist[bot] (Migrated from github.com) commented 2026-04-03 02:42:43 +00:00

medium

Adding packages: ["."] to pnpm-workspace.yaml is generally unnecessary for a single-package repository. For such projects, it is recommended to move the onlyBuiltDependencies configuration to the pnpm field in package.json and remove the pnpm-workspace.yaml file entirely. This simplifies the project structure and avoids the overhead of pnpm's workspace logic.

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) Adding `packages: ["."]` to `pnpm-workspace.yaml` is generally unnecessary for a single-package repository. For such projects, it is recommended to move the `onlyBuiltDependencies` configuration to the `pnpm` field in `package.json` and remove the `pnpm-workspace.yaml` file entirely. This simplifies the project structure and avoids the overhead of pnpm's workspace logic.
Sign in to join this conversation.
No description provided.